refactor: establish Window folder feature - #339
Open
jderochervlk wants to merge 2 commits into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd58c8e5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
2 times, most recently
from
August 5, 2026 12:14
12729ec to
3b1aed6
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
3 times, most recently
from
August 5, 2026 13:40
b207636 to
e780e3c
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 13:57
e780e3c to
6690f7b
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 14:00
6690f7b to
37eda66
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 14:30
37eda66 to
5e86112
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 14:50
5e86112 to
91f61e9
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 15:10
91f61e9 to
bb678e0
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 15:45
bb678e0 to
56e850b
Compare
jderochervlk
force-pushed
the
codex/option5-window-folder
branch
from
August 5, 2026 17:40
56e850b to
76afebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 29 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #338.
Summary
src/windowfolder on the unqualified internalWindowfeatureWebAPI.DOMsource entry and the old standalone History/VisualViewport source featuresDependency note
The provisional map listed only HTML. Existing Window, Document, and global signatures also expose Media, Storage, Messaging, Crypto, Performance, and ViewTransitions types. Those public domains are declared explicitly; HTML already supplies DOMNodes, Animation, CSSOM, Geometry, File, and foundational event/DOM layers.
Resolved temporary state
This PR removes the broad source feature named
WebAPI.DOM. Supported qualified features can now expand through the top-level implication map without colliding with a legacy source entry;WebAPI.Windowwas verified directly.Temporary state
WebWorkersTypescache/worker support module andBaseFilefoundation coupling remain for final helper cleanupReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features WebAPI.Windownpm run buildnpm testnpm run format:checkgit diff --check